Ticket #313 (closed defect: fixed)

Opened 8 years ago

Last modified 2 years ago

Linktracking optimizations and other fixes

Reported by: vincent.fretin@… Owned by: BrianKoontz
Priority: normal Milestone: 1.2
Component: core Version: 1.1.6.2
Severity: normal Keywords: optimization linktracking trunk-ported
Cc:

Description (last modified by DotMG) (diff)

Here is a patch with optimizations a bug fixes for linktracking.

There is a bug with linktracking in Action()
We StartLinktracking() at the end of the function whatever we forceLinkTracking=0 or 1.
Thus links of the body and footer are tracked with the show handler. We have to StartLinkTracking only when $_SESSION[linktracking"] was equal to 1 before we Stop it. Look at the patch for the fix.

Now, the WriteLinkTable() method use n INSERT queries.
We can only use one! (thanks to DotMG).
And I added a comparison to not link to the page itself.
example: "from_tag:FormattingRules to_tag:FormattingRules" was recognize. Now it's not.

Fixed the IsWikiName regexp. It have to be the same that the one in the formatter!

in formatter/wakka.php:
- replace -{4,}|---| by -{3,}
- delete uneeded parentheses in the big regexp (and we use $thing=$thing[0]; in wakka2callback). This improve performances.


Fixed at [175].

Attachments

Wikka-1.1.6.2_linktracking_optimizations.patch Download (4.2 KB) - added by vincent.fretin@… 8 years ago.

Change History

Changed 8 years ago by vincent.fretin@…

Changed 8 years ago by DotMG

  • keywords optimization linktracking added
  • owner changed from unassigned to DotMG
  • version set to 1.1.6.2-beta
  • status changed from new to assigned
  • milestone set to 1.1.7.1

Related ticket : #315

Changed 8 years ago by DotMG

  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)
  • milestone changed from 1.1.7.1 to 1.1.7

Changed 8 years ago by DarTar

Fixed in [175].

DotMG, when closing a ticket, please refer to the relevant changeset (this will help building a changelog when releasing the next upgrade). Also, remember to add the relevant ticket number as a SVN comment when committing code, I see [175] doesn't refer to any ticket.

Changed 7 years ago by DarTar

  • version changed from 1.1.6.2-beta to 1.1.6.2

Changed 5 years ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

Changed 5 years ago by DarTar

  • keywords trunk-ported added
  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone changed from 1.3 to 1.2

Mahefa, I was wondering if you could backport this to 1.2 (it's already coded and it might be a useful patch before I commit a fix for #882)

Changed 5 years ago by BrianKoontz

(In [1426]) Backported from trunk. Refs #313.

Changed 5 years ago by BrianKoontz

  • owner changed from DotMG to BrianKoontz
  • status changed from reopened to assigned

Changed 5 years ago by BrianKoontz

  • status changed from assigned to testing

Changed 5 years ago by BrianKoontz

  • status changed from testing to commit

No comments despite recent heavy testing of 1.2 branch.

Changed 5 years ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

Changed 2 years ago by DotMG

(In [1850]) The new categorization process. refs #809, #313, #315, #233 Re-submitting [179], [185], [190]

Note: See TracTickets for help on using tickets.