Ticket #998 (closed defect: fixed)

Opened 23 months ago

Last modified 15 months ago

Unknown handler breaks the layout

Reported by: DarTar Owned by: TormodHaugen
Priority: normal Milestone: 1.3.1
Component: core Version: 1.2
Severity: normal Keywords:
Cc:

Description (last modified by TormodHaugen) (diff)

Try loading a page and appending a string that doesn't match any existing handler (e.g. /foo): the page layout is broken.

Also; try loading a page and appending a string that contains "special characters (e.g. /øøø: the page layout is broken.

The method calling the handler should display an error message that doesn't break the layout. I think this is a small fix, so I add it to the 1.3 milestone.

Change History

Changed 17 months ago by TormodHaugen

  • owner changed from unassigned to TormodHaugen
  • status changed from new to assigned

Changed 17 months ago by TormodHaugen

There is also an error if the handler contains special characters. This should probably be reconsidered now that we accept UTF-8 characters.

Changed 17 months ago by TormodHaugen

  • status changed from assigned to testing

(In [1748] and [1749]) Wrapped handler errors in the content tags. Refs #998

Changed 17 months ago by TormodHaugen

  • description modified (diff)

The change in the gettext branch is in the spirit of how it looked there. Please test it especially well. :)

Changed 17 months ago by DarTar

Tormod, there is a fatal error when using non-ASCII handler names:

Fatal error: Call to undefined function wrapHandlerError() in /Users/dartar/svn_3.4/1.3_gettext/libs/Wakka.class.php on line 3107

Changed 17 months ago by TormodHaugen

(In [1750]) Bugfix. Forgot -> for method call. Refs #998

Changed 17 months ago by BrianKoontz

  • status changed from testing to commit

Works for me.

Changed 17 months ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

Changed 15 months ago by BrianKoontz

  • milestone changed from 1.3 to 1.3.1

Changed milestone to 1.3.1

Note: See TracTickets for help on using tickets.