Porting language constants trunk->1.3

[DarTar]

This is a coordination ticket to be used in preparation of multilanguage support and language packs in 1.3.

Translation-ready code will have to be ported from trunk to branches/1.3 and the main lang file reviewed accordingly. In those cases in which the two versions of the code are too different in functionality or structure a decision will need to be made as to what version to include in the 1.3 branch.

This ticket applies to actions, handlers and core methods. Please strickethrough the component name from the list below when its language constants have been ported.

Review pages

• actions
• handlers
• core methods

[MasinAlDujaili]

ref #340

[MasinAlDujaili]

(In [1557]) language strings refs #959, action review refs #654

[MasinAlDujaili]

(In [1559]) refs #959, small corrections to fit to constant string conventions

[DarTar]

(In [1560]) [m] fixed typo in [1557], refs #959 and #654

[DarTar]

link to handler list

[MasinAlDujaili]

(In [1562]) refs #654 & #959, merged trunk & 1.3

[MasinAlDujaili]

(In [1565]) refs #959, additional string found, changed constant names

[MasinAlDujaili]

(In [1569]) refs #654 & #959

[MasinAlDujaili]

(In [1573]) refs #959, removed string constants

[MasinAlDujaili]

(In [1574]) refs #654 & #959, strings 2 constants, removed constants, sanitized input (GetSafeVar)

[MasinAlDujaili]

(In [1581]) refs #959, removed constant strings

[MasinAlDujaili]

(In [1590]) refs #959, update

[MasinAlDujaili]

(In [1592]) refs #654 & #959

[MasinAlDujaili]

(In [1593]) refs #654 & #959, i18n, merging trunk and 1.3, cosmetic corrections

[MasinAlDujaili]

(In [1594]) refs #654 & #959, phpDoc for Menulets, small corrections

[DarTar]

(In [1603]) Removing constant declared twice, refs #654 and #959

[DarTar]

(In [1605]) Removing define in lang file comments, refs #959

[MasinAlDujaili]

(In [1618]) refs #959 & #654 (although this ticket mentions actions only, I made all the important stuff to the handlers, too)

[MasinAlDujaili]

handler backlinks

Notice: Undefined index: tag in /home/htdocs/web203/html/test/handlers/backlinks/backlinks.php on line 48 on page CategoryCategory

handler clone

Notice: Use of undefined constant VALID_PAGENAME_PATTERN - assumed 'VALID_PAGENAME_PATTERN' in /home/htdocs/web203/html/test/handlers/clone/clone.php on line 80

Warning: preg_match() [function.preg-match]: Delimiter must not be alphanumeric or backslash in /home/htdocs/web203/html/test/handlers/clone/clone.php on line 80

constant definition for VALID_PAGENAME_PATTERN missing

handler delcomment

Does not seem to do anything. Is it called by another handler (processcomment)?

[BrianKoontz]

(In [1623]) Escaped single quote. Refs #959.

[BrianKoontz]

(In [1624]) Escaped single quotes. Refs #959.

[BrianKoontz]

(In [1625]) Committed to trunk by mistake, reversing commits. Refs #959.

[BrianKoontz]

(In [1644]) Migrated lang strings. Refs #959.

[MasinAlDujaili]

(In [1666]) Refs #959, strings in core methods converted to language constants

[DotMG]

(In [1679]) refs #959, 3 constants are used before the lang file is loaded in case of critical problems. These constants should not be placed in lang file, but in top of wikka.php which uses them.

[GeorgePetsagourakis]

@DotMG concerning [1679]: Since the user is not required to open wikka.php and translate the globals in there, maybe it would be more logical not to define them as globals ?

[DotMG]

Replying to GeorgePetsagourakis:

would be more logical not to define them as globals ?

And then, we'll fall in the trap of them being exported again to lang files by ourselves (the Devs). Actually, they are grouped in the same lines, with comments mentioning not to move them to lang files, so, I'll let them like they are now.

[GeorgePetsagourakis]

Replying to DotMG: Thanks for the clarification.

[DotMG]

(In [1712]) refs #959 and [1679]: remove constants moved to wikka.php in [1679]

[DarTar]

We should either change the description of this ticket to reflect the new gettext-based implementation or close it as obsolete.

[BrianKoontz]

Changed milestone to 1.3.1