checkversion timeout

[DarTar]

When an admin is logged in and a network connection is not available, checkversion hangs while trying to retrieve version information from the Wikka server. A timeout limit should be explicitly set to avoid annoyingly long page generation times.

[BrianKoontz]

This action uses stream_set_timeout to drop the connection after so many pre-defined seconds. I'll take a look at this and see what is going on. I know I tested this offline, and the timeout worked fine on my test machine. I wonder if it's a PHP-related issue?

[BrianKoontz]

Possible culprit: fsockopen(). That takes a timeout parameter as well. Under some conditions, it does not appear to return after the timeout has expired. Problem is, I saw this happen only one time under OS X -- subsequent attempts to cause fsockopen() to timeout in fact triggered a return from the function call after the timeout parameter expired, as expected.

[BrianKoontz]

(In [1369]) Generate warning when network connection fails. Shorten connection timeout to 5 seconds. Refs #884.

[DarTar]

confirmed - works as expected. I ran a local Wikka instance with no network connection and the warning appeared after 5". The warning only appeared once, subsequent trials to connect fail silently without producing any noticeable delay.

[BrianKoontz]

(In [1380]) Ported from 1.1.6.7 to 1.2. Refs #868, #884.

[DarTar]

When logged in as an admin, pages containing {{checkversion}} can still take quite a long time to load. I was wondering if we could use some caching mechanism to avoid triggering the version check every time the page is loaded (this will also reduce unnecessary traffic to wikkawiki.org).

[BrianKoontz]

(In [1406]) User-defined checkversion interval added. See  http://docs.wikkawiki.org/ConfigurationOptions for details. Refs #884.

[NilsLindenberg]

Notice: Undefined index: display in …/actions/checkversion.php on line 60

[NilsLindenberg]

The else around the pat after "if (FALSE == ini_get('allow_url_fopen'))" should be unnecessary, since the return in line 136 takes care of going back in case of errors. Same for the one in lne 159.

[NilsLindenberg]

I've fixed the notice, tried to merge the doc about Brians time check intervall, seperated debug from display and generally tried to simplify the code a bit. Please test

[NilsLindenberg]

In changeset [1417]

[DarTar]

(In [1459]) Fixed layout and styling for debug messages in checkversion, refs #884

[DarTar]

Tested the timeout interval and corresponding debug code, works as expected.

[BrianKoontz]

(In [1481]) Ported from 1.2 to trunk. Refs #884, 911.