Ticket #874 (closed defect: fixed)

Opened 18 months ago

Last modified 14 months ago

Closing HTML tags in footer

Reported by: DarTar Owned by: DarTar
Priority: normal Milestone: 1.2
Component: core Version: 1.1.6.6
Severity: normal Keywords: trunk-unported
Cc:

Description

As of 1.1.6.6, the HTML page is opened in templates/header.php but closed in the Run() method.

We should move the closing tags to templates/footer.php for consistency.

This implies refactoring the microtime difference calculation. I created a new microTimeDiff() method called in the footer right before closing the HTML tags. I also moved the page generation time to a comment in the page source (there is no reason why this should be in the rendered output).

Change History

Changed 18 months ago by DarTar

(In [1349]) Moved HTML closing tags to footer and refactored page generation calculation, refs #868 and #874

Changed 18 months ago by DarTar

  • status changed from new to accepted

Please test with handlers generating different kinds of output

Changed 18 months ago by DarTar

  • status changed from accepted to testing

Changed 18 months ago by DarTar

incidentally, this should make it much easier to embed WikkaWiki in an external page template.

Changed 14 months ago by BrianKoontz

  • status changed from testing to commit

Tested with several handlers, looks OK.

Changed 14 months ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.