Ticket #861 (closed defect: fixed)

Opened 19 months ago

Last modified 12 months ago

Hardcoded paths in 1.1.6.6

Reported by: DarTar Owned by: BrianKoontz
Priority: normal Milestone: 1.2
Component: general Version: 1.1.6.6
Severity: normal Keywords:
Cc:

Description (last modified by BrianKoontz) (diff)

(reported by haknet on #wikka)

  • libs/Wakka.class.php line 334 hardcoded path
  • actions/usersettings.php line 126 hardcode path path is valid
  • handlers/page/show.php line 38 hardcode path obsolete in 1.2
  • in handlers/page/addcomment.php on line 3 should be "include_once('./libs/..." not "include_once('libs/..." path is valid

Referencing paths via the top-level directory is not "hardcoding" a path. Since all calls to Wikka originate from the wikka.php script, the directory of this script is always considered the "base" directory for all requires and includes. I would suggest the reporter might have a few configuration issues with his/her Wikka environment.

There is also a bug in Lighttpd rewrite documentation:  http://docs.wikkawiki.org/LighttpdConfig In Page History when I click the Revision [x] link I get: This page doesn't exist yet. Maybe you want to create it? When rewrite is disabled it works fine.

This really makes no sense. How can the documentation have a "bug"? Is the reporter referring to the docs.wikkawiki.org server, or his/her own server? I don't see how this could refer to the docs server, given the statement "when rewrite is enabled."

Note: this page was contributed by a user and should be reviewed before being included in the official docs!

Change History

Changed 18 months ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

Changed 18 months ago by DarTar

  • milestone changed from 1.3 to 1.2

Retargeted to 1.2

Changed 14 months ago by BrianKoontz

  • owner set to BrianKoontz
  • status changed from new to assigned

Changed 14 months ago by BrianKoontz

  • keywords Lighttpd removed
  • description modified (diff)

Changed 14 months ago by BrianKoontz

  • description modified (diff)

Changed 14 months ago by BrianKoontz

  • description modified (diff)

Changed 14 months ago by BrianKoontz

(In [1409]) Updated a few require/include paths. Refs #861.

Changed 14 months ago by BrianKoontz

  • status changed from assigned to testing

Changed 14 months ago by NilsLindenberg

  • summary changed from Harcoded paths in 1.1.6.6 to Hardcoded paths in 1.1.6.6

Changed 12 months ago by BrianKoontz

  • status changed from testing to commit

No comments despite recent heavy testing of 1.2 branch.

Changed 12 months ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.