Read/write ACLs for individual wiki users are broken

[DarTar]

As of the latest revision in trunk, it's impossible to restrict access to a page so that only a list of registered users can read it or write it. ACL wildcards work fine, while the following:

DarTar
DarTar2
DarTar3

won't allow any of these users to access the page (unless one is admin).

[DarTar]

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[myffical]

Seems to be due to a one-line typo in 1.3. When corrected, multi-user ACLs works as expected for me.

[BrianKoontz]

(In [1660]) Variable typo fixed (thanks myffical). Refs #843.

[DotMG]

Actually, ACLs are case sensitive, and this can lead to confusion, it's not always natural to know the exact camelcasing of a WikiName. IMO, it should really be case insensitive, and the code change should be simple enough by adding strtolower on both side of the equal signs. I mark the ticket as failed for now.

[BrianKoontz]

(In [1681]) ACL userlists made case-insensitive. Refs #843.

[BrianKoontz]

(In [1682]) Minor light CSS change to reduce size of ACL textareas. Refs #843.

[TormodHaugen]

Testing:

Multiline /multi-user ACL works. Entries are not case sensitive.

Seems to work nice.

[DarTar]

see also #1003, what happens if someone registers a username containing a newline?

[GeorgePetsagourakis]

Basically the ACL (aka permissions) system should be revamped and be completely based on the Database. I have described this in #613 .

[BrianKoontz]

Replying to DarTar:

see also #1003, what happens if someone registers a username containing a newline?

All non-printable ASCII chars need to be excluded in the IsWikiName() regexp.

[BrianKoontz]

Updated milestone to 1.3.1

[BrianKoontz]

(In [1765]) The following characters are not permitted as part of usernames or pagenames: [ ] { } % + | ? = < > ' " / 0x00-0x1f 0x7f , Refs #191, #843

[BrianKoontz]

(In [1784]) Merged 1.3.1 changes into trunk ([1765]-[1780],[1782]). Refs #191, #843, #1040, #1041, #38, #1042, #1043, #1018, #1045, #208, #415, #1039, #189