Ticket #830 (closed enhancement: fixed)

Opened 3 years ago

Last modified 15 months ago

New markup for eliding content in Wikka editor

Reported by: BrianKoontz Owned by: DotMG
Priority: normal Milestone: 1.3.1
Component: formatters Version: trunk
Severity: normal Keywords:
Cc:

Description

It would be useful to be able to create comments in Wikka markup or otherwise preclude certain content from being rendered on a page. Two new markup tags are introduced:

/* Content to be elided */

This tag prevents the enclosed text from being rendered to the displayed page. It also eliminates trailing whitespace so there are no gaps in the output.

``Content to be elided``

This tag is similar to the previous tag, except trailing whitespace is preserved.

Change History

  Changed 3 years ago by BrianKoontz

  • status changed from new to accepted

  Changed 3 years ago by BrianKoontz

(In [1263]) Introduce new markup to elide content in Wikka markup from appearing on displayed page. Cleaned up FormattingRules and added new markup tags, as well as existing tags for insertion and deletion. Refs #830.

  Changed 3 years ago by BrianKoontz

  • status changed from accepted to testing

  Changed 3 years ago by DarTar

  • component changed from unspecified to formatters

Brian, nice and useful addition. Two issues:

  • what is the rationale for introducing two different kinds of markup with or without trailing whitespace?
  • ``this markup`` breaks inside code blocks (backticks are common in programming languages so this may not be a good markup option.

  Changed 3 years ago by BrianKoontz

When I first coded this, I noticed that not dealing with the trailing whitespace (actually line terminators) left ugly spacing...I couldn't decide whether everyone would be happy with removing the trailing whitespace, so I just created another tag to leave the whitespace there (I'm sure someone might have a reason to do that!).

Indeed, ... does break inside the %%...%% tags. Strange, since /*...*/ is unaffected. Well, I can either toss out the tag, or fix it so it works inside a code block.

  Changed 3 years ago by DarTar

Retargeting to 1.3. Code for this ticket has already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

  Changed 3 years ago by DarTar

  • milestone changed from 1.2 to 1.3

  Changed 2 years ago by DarTar

I still think we should go for a single markup flavour (my preference goes to /* */) with whitespace trimmed.

  Changed 2 years ago by DotMG

  • status changed from testing to assigned

this markup breaks inside code blocks

  Changed 2 years ago by DotMG

  • owner changed from BrianKoontz to DotMG
  • status changed from assigned to accepted

I meant backticks inside code blocks make the whole content of the codeblock to be discarded.

  Changed 2 years ago by DotMG

(In [1641]) refs #830

For code blocks (%% ... %%) containing backticks comments ( ... ), the whole content of the code block is discarded. Added and $ anchors to the preg patter for backticks.

  Changed 2 years ago by DotMG

  • status changed from accepted to testing

  Changed 2 years ago by BrianKoontz

  • status changed from testing to commit

Tested with embedded ... and /*...*/ lines in %%...%% markup. Nothing was deleted in the rendered page, as is expected.

  Changed 2 years ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

follow-up: ↓ 16   Changed 23 months ago by BrianKoontz

(In [1668]) Fixed comment style radio buttons so that they display the correct user settings; modified labels to reflect user-slected comment styles; changed default comment style to threaded (can be overridden by user); removed unused commentsnav div in code and CSS. Refs #830.

in reply to: ↑ 15   Changed 23 months ago by BrianKoontz

Replying to BrianKoontz:

(In [1668]) Fixed comment style radio buttons so that they display the correct user settings; modified labels to reflect user-slected comment styles; changed default comment style to threaded (can be overridden by user); removed unused commentsnav div in code and CSS. Refs #830.

This change referenced the wrong ticket. The correct ticket is #380.

  Changed 15 months ago by BrianKoontz

  • milestone changed from 1.3 to 1.3.1

Changed milestone to 1.3.1

Note: See TracTickets for help on using tickets.