Safari and WikiEdit

[dartar]

(copied from SandBox - JavaWoman)

Safari crashes when I use a formatting button. (DarTar has confirmed this.) It looks like either Safari has a bug in their JavaScript implementation, or WikiEdit's JavaScript isn't (sufficiently) cross-browser, or both. While the browser shouldn't crash on encountering JavaScript it cannot handle, we certainly need an edit toolbar that's more cross-browser (it doesn't appear at all in Opera 7.2x on Windows). --JavaWoman

[DarTar]

Check whether this issue has been addressed by WikiEdit's developers.

[DarTar]

I'm not experiencing this issue any more with Safari 2.0.4/Mac OS 10.4.7, so I assume it was a buggy implementation of JS in previous versions of the browser which has now been fixed. Safari displays another weird behavior with wikiedit: when typing | it automatically fills in |[[]]. It looks like there's something wrong with the keyboard shortcuts here.

[BrianKoontz]

For the record, I'm not able to reproduce this bug using Safari 1.3.2 under OSX 10.3.7. All of the WikiEdit buttons appear to work fine.

[DotMG]

Brian, please check the HTTP_USER_AGENT sent by your browser. Normally, it should be something like Safari/300 (1.3) or Safari/400 (2.0).

the browser shouldn't crash on encountering JavaScript it cannot handle, thus, we must add some extra code to disable WikiEdit if Safari under 1.3.2 is used.

[Olivier Borowski <olivier.borowski@…>]

Opera 7.x doesn't support "selectionStart" which is necessary for WikiEdit.

I tested  swift browser (safari engine) and it works... but it shouldn't ;) => safari is badly considered as gecko

var isMZ  = isDOM && (navigator.appName=="Netscape")
var ua = navigator.userAgent.toLowerCase();
var isSafari = (ua.indexOf("safari") != -1);

has te be replaced by :

var isAWK = (ua.indexOf("applewebkit") != -1);		// AppleWebKit (Safari)
var isMZ  = (!isAWK) && (ua.indexOf("gecko") != -1);	// Gecko (Mozilla)
var isKhtml = (!isAWK) && (ua.indexOf("khtml") != -1);	// KHTML (Konqueror)

Safari 1.3.2 correspond to AppleWebKit/312.8 ( useragents here) => so we should disable WikiEdit below this version.

[DotMG]

Done in [245].

[DarTar]

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[BrianKoontz]

Updated milestone to 1.3.1