{{files}} action should emit a warning if PHP config file_uploads is Off

[glennj]

I just spent a frustrating hour wondering why $_FILES was empty.

I've attached a diff file with my suggested enhancement for actions/files.php

[glennj]

diff file for addition to actions/files.php

[NilsLindenberg]

added in [1332]. Thanks to glennj.

[BrianKoontz]

The original default of the {{files}} action was to display a list of files for users who did not have upload permissions. Now, when file_uploads is Off, users do not see this table of available files. Was this intentional? It seems to me if file_uploads is Off, this should not preclude the listing of uploaded files.

Otherwise, I'm OK with changing the state of this ticket to closed.

[NilsLindenberg]

You are probably right. Will change this.

[BrianKoontz]

(In [1453]) List files even if file_uploads is disabled; provide more meaningful status messages; disable uploads via upload action if file_uploads is disabled. Refs #825.

[BrianKoontz]

(In [1457]) Fixed minor typo. Refs #825.

[DarTar]

Several warnings are still displayed if the uploads folder is not writable

Warning: mkdir() [function.mkdir]: Permission denied in /Users/dartar/Documents/Test/wikka/1.2/actions/files.php on line 77

Warning: opendir(uploads/SandBox) [function.opendir]: failed to open dir: No such file or directory in /Users/dartar/Documents/Test/wikka/1.2/actions/files.php on line 205

Warning: readdir(): supplied argument is not a valid Directory resource in /Users/dartar/Documents/Test/wikka/1.2/actions/files.php on line 208

Warning: closedir(): supplied argument is not a valid Directory resource in /Users/dartar/Documents/Test/wikka/1.2/actions/files.php on line 216

[BrianKoontz]

Can we just disable warnings for the move_uploaded_file() method for now? Maybe change the error message to something more reflective of the problem?

[DarTar]

Or maybe just backport and merge from trunk (where this has already been fixed)?

[BrianKoontz]

(In [1465]) Backported permission checks and file dir checks from trunk; moved error messages into defines. Refs #825.

[DarTar]

tested permission checks, works as expected.