Ticket #82 (closed enhancement: fixed)

Opened 9 years ago

Last modified 2 years ago

new ImageAction

Reported by: minusf@… Owned by: DotMG
Priority: normal Milestone: 1.3.3
Component: actions Version: 1.1.6.1
Severity: normal Keywords:
Cc:

Description

in my holy crusade of making wikka more corporate friendly i have rewritten another action. my new ImageAction can be found here:  http://obiit.org/wikka_patches/image_php.patch

it's nothing revolutionary, just a bit of cleanup, zapping empty class="" and a change of philosophy: it's not checking for particular parameters, it takes anything. i find this sometimes needed for onmouseover tricks, etc. so you just supply any number of attributes and they get added.

Attachments

image.php.patch Download (5.0 KB) - added by GeorgePetsagourakis 4 years ago.

Change History

  Changed 9 years ago by NilsLindenberg

see  EnhancedImageAction for another approval

  Changed 8 years ago by DarTar

bump

  Changed 8 years ago by NilsLindenberg

  • milestone changed from 1.1.6.2 to 1.1.6.3

  Changed 8 years ago by DotMG

  • owner changed from unassigned to DotMG
  • status changed from new to assigned

Not for this release again.

  Changed 8 years ago by DotMG

  • milestone changed from 1.1.7 to 1.1.7.1

  Changed 5 years ago by BrianKoontz

  • milestone changed from 1.2.1 to 1.3

  Changed 4 years ago by BrianKoontz

  • milestone changed from 1.3 to blue-sky

Changed 4 years ago by GeorgePetsagourakis

follow-up: ↓ 9   Changed 4 years ago by GeorgePetsagourakis

Have a look at the image.php.patch I attached to this. I think it is a clear coding style compliant way to get an image action ;)

in reply to: ↑ 8   Changed 4 years ago by GeorgePetsagourakis

Adding to GeorgePetsagourakis: I have also tested it against the current 1.3 branch.

  Changed 2 years ago by DotMG

  • milestone changed from blue-sky to 1.3.3

  Changed 2 years ago by DotMG

  • status changed from accepted to closed
  • resolution set to fixed

(In [1848]) fixes #82

  • The new ImageAction takes note of  http://wikkawiki.org/EnhancedImageAction and patch provided by GeorgePetsagourakis on ticket #82.
  • Added a hard-coded configuration to check if image is valid and can be loaded.
  • A better handling of the mandatory alt parameter. If it is not provided, we use the title parameter (if specified) or the URL of the image.
Note: See TracTickets for help on using tickets.