Ticket #798 (closed defect: fixed)

Opened 11 months ago

Last modified 4 months ago

Parse error in Wakka.class.php

Reported by: BrianKoontz Owned by: BrianKoontz
Priority: high Milestone: 1.3
Component: core Version: trunk
Severity: major Keywords:
Cc:

Description

The following error may be generated when attempting to run latest trunk (revision 1200) with PHP version < 5:

Parse error: parse error, unexpected '=', expecting ')' in /var/www/wikka-trunk/libs/Wakka.class.php on line 566

This is due to PHP not accepting values assigned to pass-by-reference default function arguments prior to PHP 5 (as is currently defined in the IncludeBuffered() arg list).

For more info, see  http://devzone.zend.com/article/1714-Whats-New-in-PHP-5 (search for "default values for by-reference parameters").

Change History

Changed 10 months ago by BrianKoontz

  • status changed from new to accepted

The only kludge at the point would be to define two versions of IncludeBuffered(), one for PHP < 5 and another for PHP >= 5. Since no code is currently using the error flag, I've decided to back these changes out. There still exists a need to determine the error status of IncludeBuffered(), but for now users will simply have to determine the error status themselves by parsing the return value of the function.

Changed 10 months ago by BrianKoontz

(In [1224]) Removed changes to IncludeBuffered() due to incompatibility with PHP 4.x. Refs #798.

Changed 10 months ago by BrianKoontz

  • status changed from accepted to closed
  • resolution set to fixed

Changed 4 months ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

Note: See TracTickets for help on using tickets.