History is not accessible if the page is to big

[NilsLindenberg]

If you try to access the history for the SuggestionBox you'll get an server-error (500). Perhaps related to the size of the history? --NilsLindenberg

A rough estimate: there have been between 425 and 450 revisions of that page; the current page **source** size is 92316 bytes; given that the page tends to grow but is sometimes "weeded" when suggestions are implemented or moved to a separate page, the total 'history' **source** size could be something like 12.5MB. Even is it's as "small" as 5MB I wouldn't be surprised to have it break //somehow// (DB access, PHP timeout...).

Maybe we should just give up on 'history' and support only revisions? Where or how something like this breaks is hard to tell, it could be entirely dependent on a specific installation. --JavaWoman

Related tickets

• #475

[vincent.fretin]

optimization of the history handler

[vincent.fretin]

In the patch, I replaced:

"<ins>".$this->Format(implode("\n", $added))."</ins><br />";

by:

$this->Format('&pound;&pound;'.implode("\n", $added).'&pound;&pound;').'<br />';

It's needed if you want to fix #333

[DotMG]

Done in 4 step.

[207] : Replacing select * by select note, id, time user -- and adding LIMIT $max to the SQL query

[208] : A code cleanup (in respect to WikkaCodingGuidelinesHowTo)

[210] : Allowing viewing history step by step if page is too big. Adding new config entry pagesize_max to limit the size of the output html.

Todo : Allowing viewing revisions (revisions handler) step by step if page has too many revisions

Todo : Fixing #333 for history.php

[DotMG]

[211] : Added (forgotten) LoadOldestRevision() method.

[212] : Allowing viewing revisions (revisions handler) step by step if page has too many revisions

Todo : phpDoc for diff.php and revisions.php

[DarTar]

See #475 for a related issue

[DarTar]

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[BrianKoontz]

Updated milestone to 1.3.1