actions/files.php has numerous issues

[minusf@…]

(please note that this is for 1.1.6.1 but i can't choose it in the ticket properties)

the files action seriously breaks validation and has some other issues also. i didn't even bother to make a patch, i have made a new version.

CryDust has also made a much more improved version ( http://wikkawiki.org/FilesAction) i don't understand why it wasn't merged before 1.1.6.1

my version is very similar, i would like to see committed perhaps a combined version of mine and CryDust's. up to you.

my version adds one more parameter: total="1", if set, adds a total line to the file table.

my version can be found at  http://obiit.org/wikka_patches/files_php.patch and  http://obiit.org/wikka_patches/files.xml_php.patch

one more thing, the handling of "file too big to upload" is not working. but i don't have a fix for that. both ie and firefox just throw an error page.

Related tickets

#46 #89 #484 #480 #403 #257 #184 #118 #766

[DarTar]

bump - anyone willing to take a look at this?

[DarTar]

Moving to 1.1.6.3 and changing priority

[vincent.fretin@…]

You should not use a link to do update/delete tasks. It's dangerous! For example with GreaseMonkey extension for Firefox with the "Greased Lightbox" script. I click on the link to view the image. The GreaseMonkey script seems to parse the page and follow the links. The consequence is that you view the image and it have been deleted!

So you should replace the delete link by a button, action="post" to fix it.

[DarTar]

Preliminary cleanup committed as [217].

Added a long list of todo's - please check out this code and help debug :)

[DarTar]

Further code modification by DotMG: [219]

[DarTar]

Fixed minor issue with variable initialization: [224]

[DarTar]

Note: [217] also introduces an 'intranet mode' option, useful for protected environments. A similar request was posted in #392

[DarTar]

#430 suggests adding the max upload size setting to the global config, which I'm reluctant to do since:

• this option is already available in the configurable action defaults as of the latest revision in trunk to be included in 1.1.7
• we need a better way to handle action settings instead of populating the config file with options

[DarTar]

We should possibly take into account this suggestion to allow linking of uploaded images:

 http://wikkawiki.org/FilesAction#hn_making_uploaded_images_useful

[JavaWoman]

Replying to DarTar:

Moving to 1.1.6.3 and changing priority

it's 1.1.7 now!

[JavaWoman]

(In [719]) Advanced FormOpen()

• Wakka.class.php:
  • replacing FormOpen() by an adapted version of the "advanced" version available and operational on wikkawiki.org
  • adding a new existsHandler() method to support this
• files.php action:
  • now uses advanced FormOpen() to build upload form - refs #72
• more work on internationalization - refs #340

• language file (en.inc.php)
  • standardized and expanded strings for files action - refs #340

Note:

The new FormOpen() now does away completely with the silly "hidden" field that seems to have been "necessary" at some time in the past to make form submission work when rewrite_mode is not on. It is no longer necessary: FormOpen() uses Href() which provides a complete action URL including a wakka parameter. Another case of replacing addressing symptoms by addressing causes...

refs #496

[DarTar]

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[DarTar]

Nils, I am keeping this in 1.2 since INTRANET_MODE has been announced since an ugly long time, can you please take care of this?

[NilsLindenberg]

(In [1418]) refs #72: use of FormOpen() instead of reyling on own functions

[BrianKoontz]

There should be some effort in the download functionality to determine mime type. Nothing worse than being forced to download an image file, or have a binary file interpreted as an ASCII file. I have some mime-handling code in a trunk version I'm running for one of my sites ( http://www.exatorq.com/PhotoGallery); click on the first "Dyno chart" link to see if you think this is a better way of handling things. If so, I'll check in what I have.