MyChanges won't sort by timestamp

[anonymous]

The mychanges action does not properly sort by timestamp.

Status

draft of new action contributed by user - to be checked for security

Ref

 http://wikkawiki.org/MyChangesAction

[DarTar]

Code contribution available.

To do:

• code cleanup and security check;
• apply coding guidelines;
• integrate with  http://wikkawiki.org/UserChanges
• (later) replace with general purpose changes.php action #143

[DarTar]

While trying to see if I could add the proposed code to the 1.1.6.2 codebase I bumped into an important issue. The code contributed by TimoK relies on MySQL methods (like DATE_FORMAT() that are incompatible with Wikka's minimal requirements (MySQL 3.23.X). So if we want to preserve backward-compatibility we'll need to find another solution.

[BrianKoontz]

I'm confused as to what this ticket refers to. The mychanges action appears to sort by timestamp correctly in trunk. Is the proposal to replace the current mychanges action code with that in  http://wikkawiki.org/UserChanges?

[JavaWoman]

It sorts by timestamp (correctly, if teh whole timestamp is take); what was intended (see  http://wikkawiki.org/MyChangesAction !) is a sort by day (without time) and within that by page name, and then by time within pagename: otherwise, if there are a lot of changes on a date, finding a particular page in that list isn't easy. With the proposed sorting pages are grouped together per day.

The trick is to find a workaround for DATE_FORMAT...

Then, UserChanges should implement the same method (it has the same problem MyChanges now has).

[JavaWoman]

Oh, and RecentChanges of course has the same problem - only more so!

[DarTar]

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[BrianKoontz]

(In [1617]) Sort by timestamp works as expected. Refs #50.

[DotMG]

Testing, I'm lost at the spirit of this ticket, regarding comments by JavaWoman. If the intended behaviour is to sort by date (Y-M-D) then by Pagename, it's not yet what's happening.

[BrianKoontz]

JavaWoman's original assertion is invalid, because currently LoadRecentlyChanged() only returns pages that have 'Latest'=='Y'...this implies only one instance of a given page tag will ever be returned. I believe the description of this ticket was very straightforward: For whatever reason, pages weren't being sorted by timestamp. Now they are. I don't believe there's anything more to read into this. (The same argument applies to the MyChanges action.)

If, down the road, someone wants to change the functionality such that X latest edits are returned, and are sorted by day/tag/time, then a new enhancement ticket should be submitted.

Since the two lists of pages appear to be correctly sorted by timestamp, I'm closing this.

[BrianKoontz]

Updated milestone to 1.3.1