Avoid use of LoadAllPages() and remove this method

[DotMG]

LoadAllPages() uses a lot of RAM if there is a large number of big size pages. The unused LoadPageTitles() method is a good candidate to replace it.

---

Related tickets #75 #117

[DotMG]

Done in [260] The method LoadAllPages() was not removed because there may be some wikka customization using this method. Maybe, we could replace it by an alert saying it's deprecated?

[JavaWoman]

The LoadpagesByOwner() function is a great idea, but in my testing (profiling the time taken for the action) it doesn't actually make much of a difference in speed (though it could be more pronounced with very many pages). However by adding an index on the owner column I suddenly see a 10-fold speed increase - I expected some, but not that much! Obviously, this would need a DDL change in the installer.

Other observations:
- using GetUserName() as parameter is slightly inefficient since $username? is already available by checking for logged in user: this can be used directly
- adding DISTINCT (more efficient) and ORDER BY tag (sorted result, like in LoadAllPages) to the query also helps - the latter is actually needed since the action counts on this order to format the output.

Reopening this...

[JavaWoman]

In [589] the call in the mypages action has been changed to use $user['name'] instead of $this->GetUserName().

[JavaWoman]

Replying to JavaWoman:

Other observations:
- using GetUserName() as parameter is slightly inefficient since $user['name'] is already available by checking for logged in user: this can be used directly
- adding DISTINCT (more efficient) and ORDER BY tag (sorted result, like in LoadAllPages) to the query also helps - the latter is actually needed since the action counts on this order to format the output.

Query was corrected in [622] in the course of reformatting all queries (warning: long page!).

That leaves the index to be added (to be tackled in installer #97)

[DotMG]

(In [928]) Creating index on field owner to accelerate queries for method LoadPagesByOwner().

refs #398, #97

[DarTar]

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[BrianKoontz]

(In [1544]) Ported [260] from trunk to 1.3. Refs #398, #912.

[BrianKoontz]

(In [1545]) Ported [928] from trunk to 1.3. Refs #398, #912.

[DotMG]

Testing failed :

I tested the mypages action and I got the error MYPAGES_NOT_LOGGED_IN, although I'm logged in. The cause of this first issue is that $this->registered was introduced in libs/Wakka.class.php, and it isn't initialized when $this->SetUser() is not called.

[DotMG]

(In [1636]) Refs #398

• In libs/Wakka.class.php, a proper initialization of $this->registered was needed.
• In actions/mypages/mypages.php : Removed test with $page[owner] , because actually, all items returned by LoadPagesByOwner are pages owned by the user.
• In lang/en/en.inc.php : Changed "You" to "%s", because MyPages now can list pages owned by a given user (for admin). This change shoud be propagated to other lang.

[DotMG]

(In [1637]) refs #398

[928] not correctly ported into 1.3 : added creation of index idx_owner on column `owner' of table _pages

[BrianKoontz]

Tagged to indicate database change.

[BrianKoontz]

All checks out here.

[BrianKoontz]

Updated milestone to 1.3.1