Sanitize LoadRecentComments() and LoadRecentlyCommented()

[DotMG]

The (currently unused) $limit parameter in LoadRecentComments() and LoadRecentlyCommented() is not sanitized.

Note:

For unmodified installations, there is NO SECURITY RISK as all original releases of WikkaWiki (including versions prior to 1.1.6.2) do not make use of this parameter.

Where does this apply:

If the owner of a WikkaWiki-powered website modifies the installation, and adds new functionality making use of this parameter, then the value passed to this parameter is not sanitized and could raise a potential vulnerability (SQL injection).

Solution:

To sanitize it, use

$limit = intval($limit) 

---

Fixed in [241]

[JavaWoman]

changing milestone to 1.1.6.3 security release

[JavaWoman]

reopening for 1.1.6.3 (note it's fixed in trunk!)

[JavaWoman]

1.1.6.3: [405] applies [227]:[241] diff from trunk (#383) and adds and updates a few docblocks; some manual conflict resolution

[DarTar]

Since the necessary code changes have been ported, I'm closing this ticket.