Ticket #380 (closed task: fixed)

Opened 8 years ago

Last modified 4 years ago

CSS changes for 1.3

Reported by: DarTar Owned by: DarTar
Priority: normal Milestone: 1.3.1
Component: layout Version: 1.1.6.2
Severity: normal Keywords:
Cc:

Description (last modified by DarTar) (diff)

This is a coordination ticket for stylesheet-related changes to be included in 1.3.

  • Add missing CSS selectors for Wikka elements (consider though that many page components can be styled using contextual selectors) #270
  • Improve styling for files action (make it visually compatible with table styling #72)
  • Improve general styling (without major changes to the default look of the page)
    • Remove useless box at the page level (it reduces horizontal space)
    • Add styling for missing HTML elements, e.g. hr, label #251 etc.

Change History

  Changed 8 years ago by DarTar

  • owner changed from unassigned to DarTar
  • status changed from new to assigned

  Changed 8 years ago by DarTar

  • description modified (diff)

Removed useless box at the page level, added hr support, improved styling for input fields - [225]

  Changed 8 years ago by DarTar

  • description modified (diff)

  Changed 7 years ago by DarTar

(In [451]) Adding style options for feedback form, refs #486 and #380

  Changed 7 years ago by DarTar

(In [452]) Removing semantically invalid markup, adding styling and caption. The action needs to be rewritten to comply with the coding guidelines and to avoid hardcoded defaults, refs #380

  Changed 7 years ago by DarTar

(In [457]) Adjusting width for feedback form, refs #486 and #380

  Changed 7 years ago by DarTar

(In [469]) Adding icons for threaded comments navigation, refs #380 and #418

  Changed 7 years ago by DarTar

(In [470]) Adding CSS selectors for comments navigation, refs #380 and #418

  Changed 7 years ago by DarTar

(In [507]) Minor changes to newpage action:

  • fixing and consolidating l10n strings, refs #340
  • adding accessibility options, refs #388
  • adding page existence check
  • adding styling options, refs #380

  Changed 7 years ago by DarTar

(In [508]) Minor cosmetic changes for threaded comments, refs #418 and #380

  Changed 7 years ago by DarTar

(In [510]) Minor restyling for revisioninfo header (do we like a fixed div?), refs #380

  Changed 7 years ago by DarTar

(In [511]) Applying FormatUser() to history + slightly improved styling for revisions and history, refs #380 and #221

  Changed 7 years ago by DarTar

(In [512]) Last commit for today :) further layout improvements for show handler, refs #380

  Changed 7 years ago by DarTar

(In [518]) Fixing style and adding comments in the stylesheet for threaded comments, refs #418 and #380

  Changed 7 years ago by DarTar

(In [519]) Applying revisioninfo header to /diff handler, refs #380

in reply to: ↑ description   Changed 7 years ago by JavaWoman

Replying to DarTar:

* Improve styling for files action (make it visually compatible with table styling #72)

This sounds like not using table markup at all - but the data presenting attached files is tabular data and should be marked up as such! What is needed though is to make sure it generates valid and accessible table markup - and a good geerioc style for tables will then take care of styling the output automagically. IOW - the files action doesn't belong in this ticket!

  Changed 7 years ago by DarTar

(In [725]) Minor cosmetic changes to the stylesheet, refs #380

  Changed 7 years ago by DarTar

(In [730]) Adding default styling for monospaced text (feel free to change this if you don't like the current color scheme), refs #380

follow-up: ↓ 20   Changed 7 years ago by DarTar

[739] replaces styling for invalid <xmp> element with styling for samp: the installer will have to be modified accordingly.

in reply to: ↑ 19   Changed 7 years ago by JavaWoman

Replying to DarTar:

[739] replaces styling for invalid <xmp> element with styling for samp: the installer will have to be modified accordingly.

DarTar, I searched, but I could not find any actual {{usage}} of <xmp> - including but not limited to the installer - I changed it just in case we would actually want to use markup for an example.

  Changed 7 years ago by DarTar

(In [759]) Porting new CSS from trunk to 1.1.6.4 (where applicable), refs #380 and #562

  Changed 7 years ago by DarTar

(In [760]) Replacing CSS selector for data tables (.data instead of .wikka), refs #380 and #230

  Changed 7 years ago by DarTar

(In [761]) Replacing CSS selector for data tables (.data instead of .wikka) (missed one occurrence), refs #380 and #230

  Changed 7 years ago by DarTar

(In [769]) Porting [760]-[761] to 1.1.6.4: replacing CSS selector for data tables (.data instead of .wikka), refs #380 and #562

  Changed 7 years ago by DarTar

(In [780]) Porting to trunk table styling selectors already committed to 1.1.6.4, refs #380

  Changed 7 years ago by DarTar

(In [793]) Using less funky default styling for monospaced text, replaces [730], refs #380

  Changed 7 years ago by DarTar

(In [845]) Adding styling for readonly input fields, refs #380

  Changed 7 years ago by DarTar

(In [954]) Minor change in styling for code blocks, refs #380

  Changed 7 years ago by DarTar

(In [1037]) Reverting monospaced text styling to [793] (was accidentally changed in [1021]) refs #380

  Changed 7 years ago by DarTar

(In [1038]) Restoring recentchanges action styling (was accidentally changed in [1021]) refs #380

  Changed 7 years ago by DarTar

(In [1039]) New color scheme for code blocks, refs #380

  Changed 6 years ago by DarTar

(In [1080]) default styling for select elements and slight change to referrer handler styling, refs #1 #380 and #388

  Changed 6 years ago by DarTar

(In [1208]) Testing new logo + serif font scheme for headings (feedback welcome!), refs #380 and #496

  Changed 6 years ago by DarTar

(In [1209]) Removing unnecessary font declarations from stylesheet, testing Lucida Grande/Lucida Sans Unicode as main body font, refs #380 and #496

  Changed 6 years ago by DarTar

(In [1210]) Adding DejaVu Sans as default body font for Linux users, refs #380 and #496

  Changed 6 years ago by DarTar

(In [1211]) DejaVu Serif as default heading font for Linux users, refs #380 and #496

  Changed 6 years ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

  Changed 5 years ago by DarTar

  • description modified (diff)
  • summary changed from Slight CSS restyling for 1.1.7 to CSS changes for 1.3

  Changed 5 years ago by DarTar

(In [1513]) Porting styling for RecentChanges, refs #911 and #380

  Changed 5 years ago by DarTar

(In [1530]) MInor changes to light theme, refs #380

  Changed 5 years ago by BrianKoontz

  • status changed from accepted to testing

  Changed 5 years ago by DarTar

(In [1647]) Minor changes to light theme, refs #380

  Changed 5 years ago by DarTar

(In [1648]) Merging threaded comments stylesheet into main stylesheet (light template), refs #380 ans #418

  Changed 5 years ago by DarTar

(In [1649]) removing separate boxed/nested comments stylesheets (light template), refs #380 and #418

follow-up: ↓ 52   Changed 5 years ago by DarTar

(In [1650]) Adapted stylesheet for processcomment handler (light template), fixed broken layout in processcomment, now displaying the whole page before the commentform (which I think is important if one has to comment on the content!). Brian, note that because of this change when processcomment is loaded the user has to scroll to the bottom to see the comment form, we will need to find a better solution. Once we have settled on the final implementation I'll modify the other templates accordingly, refs #380 and #418

  Changed 4 years ago by DarTar

(In [1651]) Fixing inconsistency with hovers in page footer, minor changes to admin dashboard styling, refs #380

  Changed 4 years ago by DarTar

(In [1653]) [m] dashboard width, refs #380

  Changed 4 years ago by DarTar

(In [1654]) [m] looking for best styling for admin dashboard, refs #380

  Changed 4 years ago by DarTar

(In [1657]) [m] alignment of infoboxes in usersettings, refs #380

  Changed 4 years ago by DarTar

(In [1658]) Fixing layout of usersettings in kubrick theme, refs #380

  Changed 4 years ago by BrianKoontz

(In [1661]) Added anchors to take user directly to comment section when appropriate. Also added new param (anchor) to FormOpen(). Refs #380.

in reply to: ↑ 45   Changed 4 years ago by BrianKoontz

Replying to DarTar:

(In [1650])Brian, note that because of this change when processcomment is loaded the user has to scroll to the bottom to see the comment form, we will need to find a better solution. Once we have settled on the final implementation I'll modify the other templates accordingly, refs #380 and #418

See [1661]...

  Changed 4 years ago by BrianKoontz

Everything up to this point tests out OK. Dario, were you going to modify the comment layout in the kubrick theme before I close out this ticket?

  Changed 4 years ago by DarTar

yes, I need to apply the same changes to the other two themes, should be pretty straightforward. Thanks for the anchor parameter!

  Changed 4 years ago by DarTar

(In [1662]) Fixed comments style in kubrick theme. Note: the comment navigation icons and the commentsnav div will need to be removed from the show handler and CSS. The label of the fieldset in the user settings can then drop the word "default". refs #418 and #912

  Changed 4 years ago by DarTar

(In [1663]) Fixed comments style in default theme. Note: the comment navigation icons and the commentsnav div will need to be removed from the show handler and CSS. The label of the fieldset in the user settings can then drop the word "default". refs #418 and #912 and #380

  Changed 4 years ago by BrianKoontz

  • status changed from testing to commit

(In [1668]) Fixed comment style radio buttons so that they display the correct user settings; modified labels to reflect user-slected comment styles; changed default comment style to threaded (can be overridden by user); removed unused commentsnav div in code and CSS. Refs #830.

(Note that the referenced ticket is in error; this should have been #380.)

Tested and verified.

  Changed 4 years ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

  Changed 4 years ago by DarTar

(In [1692]) final tweak to stylesheet, removing reference to obsolete config setting, refs #380

  Changed 4 years ago by DarTar

(In [1699]) Minor change to userpage link styling, refs #380

  Changed 4 years ago by DarTar

(In [1700]) further minor CSS changes to light theme, refs #380

  Changed 4 years ago by DarTar

(In [1702]) Minor changes for 1.3:

  • added referrerslink menulet (Credits: EmeraldIsland)
  • missing translation strings for footer (shortened link descriptions by removing unnecessary text)
  • changed default text alignment in kubrick template to "left"

refs #912 and #1004 and #380

  Changed 4 years ago by BrianKoontz

  • milestone changed from 1.3 to 1.3.1

Updated milestone to 1.3.1

Note: See TracTickets for help on using tickets.