error reporting

[NilsLindenberg]

Wikka should run with

error_reporting(E_ALL); 

instead of

error_reporting (E_ALL ^ E_NOTICE);

That means fixing all the small things like uninitialized variables. But after that it is easier to fix such things before they can become a bug.

[NilsLindenberg]

Some E_NOTICE catched in [79] and [122]. Further cleanup in [133].

[DotMG]

[272] :

formatters/wakka.php
3rdparty/core/safehtml/classes/safehtml.php
actions/files.php
libs/Wakka.class.php

[JavaWoman]

1.1.6.3: [402] applies [294]:[330] from trunk (with some confilcts resolution) for #312; also some initializations added (#38), slashes replaced by DIRECTORY_SEPARATOR (#89), and a lot of docblocks added or updated. (phew)

[JavaWoman]

Small tip: if you turn on warnings in Eclipse, it will detect a lot of (possible) missing initializations.

[DotMG]

(In [523]) refs #38

show handler: $showcomments_text in default statement of switch used .=, but it was not yet defined. Replaced with =

header action: initialization of $pagetag should occur outside of if block, as it used to throw a notice on edit.

[JavaWoman]

Replying to DotMG:

(In [523]) refs #38 show handler: $showcomments_text in default statement of switch used .=, but it was not yet defined. Replaced with =

Rather than changing a .= to =, actual initialization of the not-yet-defined variable would be cleaner and more maintainable.

[DotMG]

(In [1642]) refs #38. Suppressing Notices

[DotMG]

(In [1643]) refs #38

I made a script to detect all possible constant used in the Wikka but not defined anywhere. It showed that the following constants aren't defined :

• RFC_MAX_EMAIL_LINE_LENGTH (libs/Compatibilily.lib.php)
• NO_PAGES_FOUND_MESSAGE (actions/category/category.php)
• STATUS_NO_PAGES_EDITED (actions/mychanges/mychanges.php)

For RFC_MAX_EMAIL_LINE_LENGTH, I don't know if it should be defined by PHP, a Web search returned no result explaining the use of this constant. For the other 2, I could make the fix.

In comments.xml and recentchanges.xml handlers, just modified VALID_FORMATS in comments to reflect FEED_VALID_FORMATS.

[BrianKoontz]

It looks like some notices for 1.3 are being handled by this ticket.

[BrianKoontz]

(In [1690]) Suppressed notice concerning uninitialized array member. Refs #38.

[BrianKoontz]

Updated milestone to 1.3.1

[BrianKoontz]

I agree. We can't be expected to catch each deprecated feature and/or coding practice worthy of a notice, so we need to be able to depend upon our users to help with this.

[BrianKoontz]

(In [1768]) Enable all error/notice messages. Refs #38.

[BrianKoontz]

(In [1774]) Suppressed a few undefined notices. Refs #38.

[BrianKoontz]

(In [1775]) Fixed notice (undefined var). Refs #38.

[BrianKoontz]

(In [1784]) Merged 1.3.1 changes into trunk ([1765]-[1780],[1782]). Refs #191, #843, #1040, #1041, #38, #1042, #1043, #1018, #1045, #208, #415, #1039, #189