Optimize page caching ($pageCache doesn't work well)

[hiRainChen@…]

how to show out the bug: set the config "sql_debugging" to 1,then at the bottom you will find such as:

...
select * from wikka_pages where tag = 'HomePage' and latest = 'Y' limit 1 (0.0024969577789307)
select * from wikka_pages where tag = 'HomePage' and latest = 'Y' limit 1 (0.0021030902862549)
...

the $pageCache doesn't work.

bug reason: 'HomePage' in the database is low case as 'homepage';

how to fix:

/lib/Wakka.class.php in the function : function LoadPage

find below code: $this->pageCache[$pagetag?] = $page;

should be : $this->pageCache[$tag] = $page;

[TormodHaugen]

The only problem I can see here is that a page is linked to with another name than what it has been created with. If the page exist as 'homepage' in the database, then 'root_page' should be set to 'homepage' in wikka.config.php?

In the function LoadPage, $tag is what the user asks for, and $pagetag? (should be $pagetag?) is what the page is actually named.

The bug here would then be that the page has been saved with the tag 'homepage' instead of 'HomePage' in the first place.

[DotMG]

I'm afraid this bug is valid. Since Wikka caches page, the query select where tag = 'HomePage' shouldn't have been executed twice. The second attempt should have read it from cache.

But the resolution proposed is not efficient. It should be

$page = isset($this->pageCache[strtolower($tag)]) ? $this->pageCache[strtolower($tag)] : null;
...
$this->pageCache[strtolower($tag)] = $page;

I look further.

[TormodHaugen]

Ok. That might be; I did my testing on trunk from svn, and did not run into the problem (only one call per page linked, even if more than one link.)

Have pages with CamelCase names and pages with lowercase names. Get extra call when asking for HomepAge, so strtolower($tag) would help as a fix against #61 (where my 3.5 cents are on "do nothing").

[DotMG]

The changeset for this ticket has fallen into a big optimization of the page caching mechanism.

Creating a mechanism for caching page loaded by LoadPageById().

Make LoadPageById() retrieve page from cache if the id was previously loaded using LoadPage().

[DotMG]

Fixed in [209] for the pagecaching.

LoadUser() can be optimized too, this will be addressed in ticket #368

[DarTar]

Hi Mahefa,

I just wanted to say that the optimization work is great! My local install really works much faster.

[DarTar]

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[BrianKoontz]

Updated milestone to 1.3.1