Linktracking optimizations and other fixes

[vincent.fretin@…]

Here is a patch with optimizations a bug fixes for linktracking.

There is a bug with linktracking in Action()
We StartLinktracking() at the end of the function whatever we forceLinkTracking=0 or 1.
Thus links of the body and footer are tracked with the show handler. We have to StartLinkTracking only when $_SESSION[linktracking"] was equal to 1 before we Stop it. Look at the patch for the fix.

Now, the WriteLinkTable() method use n INSERT queries.
We can only use one! (thanks to DotMG).
And I added a comparison to not link to the page itself.
example: "from_tag:FormattingRules to_tag:FormattingRules" was recognize. Now it's not.

Fixed the IsWikiName regexp. It have to be the same that the one in the formatter!

in formatter/wakka.php:
- replace -{4,}|---| by -{3,}
- delete uneeded parentheses in the big regexp (and we use $thing=$thing[0]; in wakka2callback). This improve performances.

---

Fixed at [175].

[DotMG]

Related ticket : #315

[DarTar]

Fixed in [175].

DotMG, when closing a ticket, please refer to the relevant changeset (this will help building a changelog when releasing the next upgrade). Also, remember to add the relevant ticket number as a SVN comment when committing code, I see [175] doesn't refer to any ticket.

[DarTar]

Retargeting to 1.3, this ticket has already been closed in trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

[DarTar]

Mahefa, I was wondering if you could backport this to 1.2 (it's already coded and it might be a useful patch before I commit a fix for #882)

[BrianKoontz]

(In [1426]) Backported from trunk. Refs #313.

[BrianKoontz]

No comments despite recent heavy testing of 1.2 branch.