Problem with the SQL query of the LoadWantedPages() function with MySQL 5.0.22.

[vincent.fretin@…]

There is a problem with the SQL query of the LoadWantedPages() function with MySQL 5.0.22. With Mysql 5.0.22, it seems the field name tag from pages table has priority on the alias "wikini_links.to_tag as tag", and so the "group by" statement doesn't work as expected and so the WantedPages page give you false result.

Here is the original query:

select distinct wikka_links.to_tag as tag,count(wikka_links.from_tag) as count from wikka_links left join wikka_pages on wikka_links.to_tag = wikka_pages.tag where wikka_pages.tag is NULL group by tag order by count desc

I propose to rename the tag alias to page_tag:

select distinct wikka_links.to_tag as page_tag,count(wikka_links.from_tag) as count from wikka_links left join wikka_pages on wikka_links.to_tag = wikka_pages.tag where wikka_pages.tag is NULL group by page_tag order by count desc

And there are 3 modificiations to do in actions/wantedpages.php and one modification in IsWantedPage() function in libs/Wakka.class.php

The above changes give you good results in the WantedPages page.

[vincent.fretin@…]

tag->page_tag, _REQUEST->_GET, uniformization/optimization

[vincent.fretin@…]

You can delete the first patch (Wikka-1.1.6.2-LoadWantedPages-MySQL-5.0.22.patch), there is an error. LoadWantedPages-MySQL-5.0.22.patch is the good one.

[DarTar]

done

[vincent.fretin]

tag->page_tag, _REQUEST->_GET, uniformization/optimization (this one apply cleanly against trunk)

[Mokoshi]

Please apply it! (you can delete all previous patches)

[DarTar]

[410] applies the patch to trunk, thanks!

[BaxilDragon]

Just as a heads-up, I applied this patch to my 1.1.6.2 installation, and while it fixed the listed problem, it left the backlinks action broken. I think the "tag" needs to be changed to "page_tag" in that action as well.

[BaxilDragon]

... Never mind; I made an error while applying the patch.

[ajmh]

This problem is still present in the 1.1.6.4 code base. I would recommend changing the SQL to reference the actual table and column which is being grouped by explicitly to avoid any future issues with implicit column aliasing (rather than chasing changed aliases around the rest of the code base).

Line 710 in Wakka.class.php could be changed to the following:

function LoadWantedPages() { return $this->LoadAll("select distinct ".$this->configtable_prefix?."links.to_tag as tag,count(".$this->configtable_prefix?."links.from_tag) as count from ".$this->configtable_prefix?."links left join ".$this->configtable_prefix?."pages on ".$this->configtable_prefix?."links.to_tag = ".$this->configtable_prefix?."pages.tag where ".$this->configtable_prefix?."pages.tag is NULL group by ".$this->configtable_prefix?."links.to_tag order by count desc"); }

[ajmh]

Fixed 1.1.6.4 Wakka.class.php file

[ajmh]

Replying to ajmh:

Sorry - form garbled my output. I've attached a complete copy of a patched version of the Wakka.class.php library file from the 1.1.6.4 distribution.

[ajmh]

Replying to ajmh:

After having a look at the trunk the SQL is still using the aliased column name (rev 1071, line 1717).

[NilsLindenberg]

Moving to 1.1.6.5

[DarTar]

(In [1143]) Replace alias with actual column name in LoadWantedPages(), thanks ajmh for the patch, fixes #309

[DarTar]

Before marking this as 1.1.7-ported, can someone please explain the rationale for two separate methods (LoadWantedPages() and LoadWantedPages2()) in trunk? Shouldn't we just have a backward-compatible LoadWantedPages() extended with the new parameters?

[DotMG]

My code! We can remove the actual code for LoadWantedPages() and rename LoadWantedPages2() as LoadWantedPages().

See #776

[DarTar]

agreed, provided the parameter list is backward-compatible.