Ticket #250 (closed enhancement: fixed)

Opened 8 years ago

Last modified 3 years ago

New RSS handler

Reported by: DarTar Owned by: DotMG
Priority: normal Milestone: 1.3.1
Component: 3rdparty Version: 1.1.6.2
Severity: normal Keywords: syndication
Cc:

Description (last modified by DarTar) (diff)

The current RSS handler should be replaced with a more flexible tool like the one tested here:

 http://wikkawiki.org/RSSHandler

As soon as we adopt a better RSS handler and we are able to produce multiple feeds for global changes, local changes, comments (#335) or other modifications (#143), a config option (#249) could be used to determine what kind of feeds must be generated and made auto-discoverable.

Related tickets

Change History

Changed 8 years ago by DarTar

  • description modified (diff)

Changed 8 years ago by DarTar

  • status changed from new to assigned
  • milestone changed from 1.1.7 to 1.1.6.3

Changed 8 years ago by DarTar

  • description modified (diff)

Updating description with ref to #335 (closed as duplicate).

Changed 7 years ago by DarTar

[367] adds the 3rdparty feedcreator class required by the new handlers.

Changed 7 years ago by DarTar

[368] adds docblock and SVN id keyword

Changed 7 years ago by DarTar

[412] adds preliminary code for feed generation handlers for recent changes and recent comments using FeedCreator.

Changed 7 years ago by DotMG

Bug in your code: comments.xml.php line 71 (replace plugins by core).

Changed 7 years ago by DarTar

[422] fixes the above issues, thanks.

Changed 7 years ago by DarTar

  • description modified (diff)

adding related tickets

Changed 5 years ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

Changed 5 years ago by BrianKoontz

(In [1512]) Ported feedcreator code from trunk to 1.3. Refs #250.

Changed 5 years ago by BrianKoontz

  • status changed from accepted to testing

Changed 5 years ago by BrianKoontz

  • status changed from testing to assigned

Changed 5 years ago by BrianKoontz

  • owner changed from DarTar to BrianKoontz

Changed 5 years ago by BrianKoontz

  • status changed from assigned to testing

Changed 4 years ago by DotMG

Actually, test could not pass because of error_reporting(E_ALL i suppose) and PHP Notices.

<b>Notice</b>:  Undefined property: Wakka::$method in <b>/home/mahefa/homemade/wikka/branches/1.4/handlers/recentchanges.xml/recentchanges.xml.php</b> on line <b>104</b><br /> 
<br /> 
<b>Notice</b>:  Use of undefined constant FEED_IMAGE_URL - assumed 'FEED_IMAGE_URL' in <b>/home/mahefa/homemade/wikka/branches/1.4/handlers/recentchanges.xml/recentchanges.xml.php</b> on line <b>109</b><br /> 

Have to tackle some part of #38 first...

Changed 4 years ago by DotMG

  • status changed from testing to assigned

Added error_reporting(E_ALL E_NOTICE); on top of my working copy to allow me to test anyway and the test failed. Links on the RSS become something like

wikka.php?wakka=rakoto&amp;time=2010-04-23+20%3A56%3A32 instead of

wikka.php?wakka=rakoto&time=2010-04-23+20%3A56%3A32, thus the parameter time is ignored.

On the xml source, it's written &amp;amp;time=

Changed 4 years ago by DotMG

(In [1635]) Refs #250

  • Removes Notices and error messages to avoid that the resulting XML feed is invalid, done in double step (Fixed FEED_IMAGE_URL not defined, replaced $this->method with $this->handler) (Added ob_start() and ob_end_clean() to catch all other possible error messages
  • Fixed double escaping of ampersands in URL

Changed 4 years ago by DotMG

  • status changed from assigned to testing

Changed 4 years ago by DotMG

  • status changed from testing to assigned

Taking ownership of the ticket ...

Changed 4 years ago by DotMG

  • owner changed from BrianKoontz to DotMG
  • status changed from assigned to accepted

Changed 4 years ago by DotMG

  • status changed from accepted to testing

Changed 4 years ago by BrianKoontz

  • status changed from testing to commit

Tested with both rewrite_mode enabled and disabled. Links work correctly.

Changed 4 years ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

Changed 3 years ago by BrianKoontz

  • milestone changed from 1.3 to 1.3.1

Updated milestone to 1.3.1

Note: See TracTickets for help on using tickets.