Including a Page with an category action leeds to wrong behavior of the action

[NilsLindenberg]

copied from SuggestionBox --NilsLindenberg

Um, I don't know how to describe this really. Put {{include page="Category Documentation"}} on the SandBox page....I can't figure out why it gives that output as Sandbox doesn't own anything.

• Looks like the weirdness is caused by the ""{{Category}}"" action which assumes the "current page" represents the category - and find pages "belonging to" a category by finding a mention of that page name. Good sign our category system does need an CategorySystemOverhaul! --JavaWoman

• Include pulls in a page that itself has the category action on it; the "official" version of this action assumes that the page it occurs on is a category. The experimental category action that is now active on this site no longer makes this assumption but recognizes that SandBox isn't a category page and defaults to the top category. See Sandbox for a an example (at this moment). --JavaWoman

• I can see that it now works, but what do you mean that it "recognizes that Sandbox isn't an action".....do you mean target page? --GmBowen

• Oops, sorry (corrected now) - I meant the new category action sees whether the page it's "sitting" on is a category page or not - if not it defaults to showing the list for the top-level category. --JavaWoman (aka IamBack)

[DotMG]

See related ticket below. I'm not sure I understand the problem here, but since you mentionned CategorySystemOverhaul here, I linked the 2 pages. (I hope this will be fixed at least at milestone:1.1.7.2 :)

Related ticket: #315

[DotMG]

Fixed at [180].

[JavaWoman]

reopening - unfortunately [180] fixes only patr of the problems described in this ticket: includes work OK now, but put {{category}} in the SandBox, and SandBox is still regarded as a "category". This isaddressed in the "new" (and by now well-proven) category2 action.

About time to implement that - reopening this ticket until I can do so!

[JavaWoman]

Assigning to myself ;)

[JavaWoman]

Actually, include does not work OK either: if the included page uses a {{category }} action that specifies a category page to be analyzed, the new mechanism would actually override this category parameter.

Solution coming up (to be replaced with advanced category action later).

[JavaWoman]

(In [621]) - cleanup (whitespace only - action needs to be replaced anyway) - update, reorganize and extend docblock - removing #312 todo (done) - correction of partial fix for #232: if this category action sits on an included page and the action tag specified a "page" parameter to state which page to analyze, this parameter would be overwritten; this no longer happens: "current (included) page" is now only considered when a "page" parameter is not specified. See #232, comments 3 and 5

refs #232

[DarTar]

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X