Ticket #230 (testing enhancement)

Opened 3 years ago

Last modified 4 months ago

Formatter support for simple table markup

Reported by: DarTar Owned by: TormodHaugen
Priority: high Milestone: 1.2
Component: formatters Version: 1.1.6.2
Severity: normal Keywords:
Cc:

Description (last modified by DotMG) (diff)

Using the excellent patch provided by Tormod Haugen:

 http://wikkawiki.org/SimpleTables

Tags: TagCanBeClosed

Attachments

simpletables_scope.patch (3.5 KB) - added by anonymous 3 years ago.
patch against svn rev 130 containing scope attrib.

Change History

Changed 3 years ago by DarTar

Patch committed in [129]

Changed 3 years ago by anonymous

patch against svn rev 130 containing scope attrib.

Changed 3 years ago by DarTar

<th> scope attribute support committed in [131] (simpletables_scope.patch).

Changed 3 years ago by DarTar

thead/tbody/tfoot support for table formatter + stylesheet selectors committed in [132].

Changed 3 years ago by DarTar

Added advanced table markup ( http://temp.tormodh.net/wakka.against.r158.patch) in [160].

Note: markup for many attributes has substantially changed from previous development version. All table elements and attributes required for accessibility are now supported.

Changed 3 years ago by DarTar

Applying patch for table attributes and styling markup ( http://temp.tormodh.net/wakka.attributes.patch) as [169]

(optional) parameters have been moved after the separator, e.g.:

|=|(x:2)This is a header spanning two columns||.

(optional) style settings can now be added using single braces, e.g.:

|=|(x:2){color:red}This header has red text||.

Changed 3 years ago by DarTar

patch uploaded as of [171] to prevent incorrect parsing of actions within cells.

Changed 2 years ago by DotMG

  • owner changed from unassigned to TormodHaugen
  • description modified (diff)

Changed 21 months ago by DarTar

(In [760]) Replacing CSS selector for data tables (.data instead of .wikka), refs #380 and #230

Changed 21 months ago by DarTar

(In [761]) Replacing CSS selector for data tables (.data instead of .wikka) (missed one occurrence), refs #380 and #230

Changed 21 months ago by DarTar

As of [761], the <table> element is not closed by the formatter if no content is added to a page other than tabular markup.

Changed 21 months ago by DarTar

This bug was introduced by some recent modification to trunk. docs.wikkawiki.org, running on an earlier trunk version  correctly renders tables

Changed 21 months ago by DotMG

(In [775]) refs #230, comment:10.

The bug was introduced by [628], which forgot the 'format_option' in the compact() function.

At least, this has shown that the strategy used for this tip is very, very opaque, and may lead, soon or later, to problem.

todo: more comments to explain the tip.

The formatters/wakka.php, is waiting for a variable named $format_option This variable is passed to the Wakka::Format() method. The Wakka::Format() method uses compact('text', 'format_option') instead of $text and $format_option. This is obscure. Wakka::IncludeBuffered() then uses extract($vars) to restore the value of $format_option.

Changed 4 months ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

Changed 4 months ago by DarTar

  • priority changed from normal to high
  • status changed from new to assigned
  • milestone changed from 1.3 to 1.2

Disregard previous change. This will be the major focus of 1.2.

Changed 4 months ago by TormodHaugen

  • status changed from assigned to accepted

Will port this over to 1.2

Changed 4 months ago by TormodHaugen

(In [1347]) Backported simple tables from trunk to 1.2. Refs #230.

Changed 4 months ago by TormodHaugen

  • status changed from accepted to testing
Note: See TracTickets for help on using tickets.