Ticket #227 (closed enhancement: fixed)

Opened 6 years ago

Last modified 15 months ago

Don't include "HomePage ::" in navigation links by default.

Reported by: bzg Owned by: DarTar
Priority: low Milestone: 1.3.1
Component: actions Version: 1.1.6.2
Severity: minor Keywords: HomePage
Cc: DarTar

Description

I often need to edit navigation links manually through wikka.config.php and i find it quite annoying that "HomePage ::" is hardcoded. I think it should be left as an option.

Change History

  Changed 6 years ago by DarTar

  • owner changed from unassigned to DarTar
  • status changed from new to assigned
  • milestone set to 1.1.6.3

  Changed 6 years ago by Mohamed Jadelrab

you can use your own text for the HomePage by modifiying the file wikka.config.php by adding

	'root_page_title' => 'الصفحة الأولى',

after

	'root_page' => 'StartPage',

and ofcourse change the text of the new line to what ever text you want or what language you want ..

then you need to edit the actions/header.php in line 31 to be

<?php echo $this->Link($this->config["root_page"],'',$this->config["root_page_title"]); ?> ::

notice adding ,,$this->configroot_page_title? in brackets !

  Changed 5 years ago by BrianKoontz

(In [560]) HomePage is now displayed in nav links as a configurable option in wikka.config.php. Refs #227.

  Changed 5 years ago by BrianKoontz

  • status changed from assigned to closed
  • resolution set to fixed

  Changed 5 years ago by DarTar

Brian, take a look at this first: http://wush.net/trac/wikka/ticket/97#comment:25

This is a bug that should be fixed, but currently we allow other names to be used for HomePage. Your patch only works with HomePage as pagename, right?

  Changed 5 years ago by BrianKoontz

  • status changed from closed to reopened
  • resolution fixed deleted

Need to add "bridging" code in the installer that properly updates nav links in version < 1.1.7 during upgrades to 1.1.7 to also include (as a default) the HomePage navlink (which is also the default in a fresh install). Also, HomePage link needs to reflect the "real name" of the HomePage as set up during upgrade/install.

follow-up: ↓ 8   Changed 5 years ago by DotMG

(In [571]) The root_page parameter entered during install will be used in the config values logged_in_navigation_links and navigation_links. The installer no longer fails if the user chooses

refs #227

in reply to: ↑ 7   Changed 5 years ago by JavaWoman

Replying to DotMG:

(In [571]) The root_page parameter entered during install will be used in the config values logged_in_navigation_links and navigation_links. The installer no longer fails if the user chooses

I'm sure I'm missing something, but I don't see how or where '_rootpage' would be turned into a link. Mohamed Jadelrab's suggestion would do it though, with or without using the title.

  Changed 5 years ago by DarTar

(In [724]) Adding a link to the homepage in the main wiki heading, refs #227 and #496

  Changed 4 years ago by DarTar

(In [842]) Adding a link to the homepage in the main wiki heading, ports [724] from trunk, refs #227 and #575 and #562

  Changed 4 years ago by DarTar

(In [843]) Forgot a tiny bit from previous commit [842], refs #227 and #575 and #562

  Changed 3 years ago by DarTar

  • milestone changed from 1.2 to 1.3

Retargeting to 1.3. Code for this ticket may have already been committed to trunk, from which 1.3 will be branched. Consider backporting urgent issues to 1.2.X

  Changed 23 months ago by BrianKoontz

  • status changed from reopened to closed
  • resolution set to fixed

I believe this ticket is no longer valid (or is fixed as well as it can be), since the "HomePage" link no longer shows up in the nav bar and has been replaced by an anchor tag on the Wikka name in the header.

  Changed 15 months ago by BrianKoontz

  • milestone changed from 1.3 to 1.3.1

Changed milestone to 1.3.1

Note: See TracTickets for help on using tickets.