Ticket #216 (closed defect: fixed)

Opened 4 years ago

Last modified 2 years ago

If wikka.config.php is deleted (and setup reruns) default pages are duplicated

Reported by: anonymous Owned by: unassigned
Priority: normal Milestone: 1.1.6.4
Component: installer Version: 1.1.6.3
Severity: normal Keywords: 1.1.7-ported
Cc: DotMG

Description (last modified by JavaWoman) (diff)

Rerunning the installer after the config file is deleted (either accidentally or intentionally to enforce rerunning an installation) results in duplicate default pages. 

Free Software Server Environment : PageIndex
HomePage :: Categories :: PageIndex :: RecentChanges :: RecentlyCommented :: Login/Register
All   C  F  H  I  M  O  P  R  S  T  U  W 

C
CategoryCategory
CategoryCategory
CategoryWiki
CategoryWiki

F
FormattingRules
FormattingRules
FsseInfo . . . . Owner: FsseInfo

H
HighScores
HighScores
HomePage . . . . Owner: FsseInfo

I
InterWiki
InterWiki

M
MyChanges
MyChanges
MyPages
MyPages

Fixed at [177]

Change History

Changed 4 years ago by DotMG

  • status changed from new to closed
  • resolution set to fixed
  • description modified (diff)
  • milestone set to 1.1.7

Changed 3 years ago by BrianKoontz

  • status changed from closed to reopened
  • version changed from 1.1.6.1 to 1.1.6.3
  • resolution fixed deleted

As reported by arfyarf via #wikka, this bug still exists as of 1.1.6.3. User restarted the install process midway, resulting in multiple default page versions all of which had the latest flags set to 'Y'.

Changed 3 years ago by DarTar

  • status changed from reopened to closed
  • type changed from enhancement to defect
  • summary changed from If wakka.config.php is deleted (and setup reruns) duplicate page entrys appear in the PageIndex to If wakka.config.php is deleted (and setup reruns) default pages are duplicated
  • resolution set to fixed
  • milestone changed from 1.1.7 to 1.1.6.4

This was already fixed by JavaWoman in 1.1.6.4. with [755], I'm changing the milestone accordingly.

Changed 3 years ago by DarTar

  • description modified (diff)
  • summary changed from If wakka.config.php is deleted (and setup reruns) default pages are duplicated to If wikka.config.php is deleted (and setup reruns) default pages are duplicated

Changed 3 years ago by JavaWoman

  • description modified (diff)

Changing description: deleting a config file intentionally to enforce rerunning the installation is probably the most usual use case; it's actually pretty hard to do so accidentally!

Changed 2 years ago by DarTar

  • cc DotMG added
  • keywords 1.1.7-unported added

Not sure all the changes committed to [755] have been also applied to trunk, needs to be reviewed.

Changed 2 years ago by DotMG

In [755], existsPage() method was changed. It consisted of letting it be called from the installer (external to the class). 3 more parameters were added. On trunk, the installer doesn't need to call existsPage() directly. The solution was simple: change latest to 'N' and add new row. Both insert and update are managed correctly.

Actual version of existsPage() is more efficient and more compact, but ... can we introduce some parameters in one release and take them back on another?

Changed 2 years ago by DarTar

I think so, especially if the change is recent and the code is on a different branch (1.1.6.x vs. 1.1.7.x) . We'll obviously need to document this in the code documentation.

Changed 2 years ago by DotMG

(In [1130]) refs #216 comments  7 and 8

Changed 2 years ago by DotMG

  • keywords 1.1.7-ported added; 1.1.7-unported removed
Note: See TracTickets for help on using tickets.