Ticket #178 (accepted enhancement)

Opened 3 years ago

Last modified 2 years ago

Disabling of links when user has no right to read target page

Reported by: MasinAlDujaili Owned by: DarTar
Priority: low Milestone: 1.3
Component: formatters Version: 1.1.6.1
Severity: minor Keywords:
Cc:

Description

I think, it could be a nice idea to format links in pages corresponding to the user's right of reading the page, e.g. like it's already done with the {{recentlychanged}} action where page names only get linked when the user has the right to read the page. This might collide with user actions where she wants to create an already existing page but it should be possible to generate a "Page already exists" or "You don't have write permissions" message -- the latter already being implemented ...

Change History

  Changed 3 years ago by DarTar

For the time being we are trying to make Wikka's behaviour consistent by filtering links in page lists depending on read-privileges.

As for links in page body, we might implement a config option allowing admins to decide whether unaccessible links should be rendered as:

  1. Raw text
  2. Links with a specific tail (a lock?)

This will be part of the overhaul of the current link formatter anyway, planned not earlier than 1.1.7

  Changed 3 years ago by anonymous

Well, it might be a good idea to handle automatically generated content different than manually generated content. Your proposal seems sound enough. I'd suggest to implement a config option for automatic content links to be displayed as

  1. raw text or
  2. not at all ...

  Changed 3 years ago by DbieL

Just so that it is not overlooked, this should also include Category listings that currently (1.1.6.2) still list pages regardless of ACL read settings.

  Changed 3 years ago by DarTar

  • owner changed from unassigned to DarTar
  • status changed from new to assigned

Good catch Dbiel, thanks for reporting this.

  Changed 2 years ago by DbieL

This ticket needs to be updated. The milestone is listed as 1.1.6.2 yet in the notes there is a reference to not being fixed until 1.1.7 or later and since it was not fixed in 1.1.6.2 and there is no reference to it being fixed in 1.1.6.3 that was just released it would be helpful if the milestone was to something in the future rather than in the past.

follow-up: ↓ 7   Changed 2 years ago by DarTar

I read:

Milestone: 1.1.7.2

what do you read?

in reply to: ↑ 6   Changed 2 years ago by DbieL

Replying to DarTar:

I read: Milestone: 1.1.7.2 what do you read? I also read 1.1.7.2 now

Not sure if I was simply blind before and misread it, or if it changed. The odds are I read it wrong, sorry about that. Thanks for the reply

  Changed 2 years ago by JavaWoman

A change to the Link() method to show link text only instead of a link when the user has no read access is trivial. And I don't see the value of showing a live link with a lock - why make it a link if you can go there but not read it anyway?

I propose we do the simple "show text only" if the user has no read access. This could easily be in 1.1.7 (I have it already in my local 1.1.6.3 copy) - I see no reason to postpone such a simple change that enhances basic usability.

Any further overhaul of the link formatter could still go into 1.1.7.2 (and is not part of this ticket).

BTW, category listings should be a separate ticket.

Note: See TracTickets for help on using tickets.