Making the edit-note mandatory

[SamuelDr (copied by NilsLindenberg)]

I think it would be a good idea to let the administrator choose if the field is mandatory.

If it is, the form doesn't submit until there is content into it, and it should warn too with an alertbox.

Only a little bit of PHP is necessary, the big part is in JS, if i don't make any mistake... --SamuelDr

Actually, for the most basic validation, you don't even need any JS. I have implemented both, but the integration of the client side validation using JS is a bit of a hack (and needs to be streamlined, and own't currently work as an administrator setting), so I'm a bit hesistant to publish it (also I'm not sure on what page, I'm still a bit new here).

The server side validation goes like this. First, add a line to wikka.config.php: "edit_note_required" => true,

Then modify handlers/page/edit.php. Find the code that says

                  // check for overwriting
                  if ($this->page)
                  {
                      if ($this->page['id'] != $_POST['previous'])
                      {
                          $error = 'OVERWRITE ALERT: This page was modified by someone else while you were editing it.<br />'."\n".'Please copy your changes and re-edit this page.';
                      }
                  }

and modify it so it says:

                  // check for overwriting
                  if ($this->page)
                  {
                      if ($this->page['id'] != $_POST['previous'])
                      {
                          $error = 'OVERWRITE ALERT: This page was modified by someone else while you were editing it.<br />'."\n".'Please copy your changes and re-edit this page.';
                      }
                  }
                  // check for edit note
                  if ($this->config['edit_note_required'] && $_POST['note']=='')
                  {
                      $error .= 'EDIT NOTE ALERT: You must include an edit note!<br/>'."\n";               
                  }

--CyneBeald

[NilsLindenberg]

the proposed soultion in a txt file for better readability

[NilsLindenberg]

//copied a very old discussion from the suggestion-box. Note the proposal from GeorgePetsagourakis!//

It is me again! What is the function of the "Please add a note on your edit" - field? Again and again: Keep on the good work.

-- SkyWalk

~& this note is shown in some lists like the RecentChanges and the page revisions. it's just a little helper to keep the wiki organized and has no effect on the page itself. use it whenever you can to drop a short abstract of what has changed, even if you have corrected some typos to let others know that no essential changes were made. it is a really useful feature --DreckFehler

maybe we could have a level switch on that feature, constituting it obligatory, optional, or off... an addittion to the conf will be neccessary thought.. --GeorgePetsagourakis

[DarTar]

Fixed in [84]. Added new config option require_edit_note. Possible values are:

• 0: edit note optional (default)
• 1: edit note required (edit handler displays error message if note is empty)
• 2: edit note disabled (note field is removed)

[JavaWoman]

Seems to have been reopened by spam removal; closing again...