Ticket #112 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

new UserSettings

Reported by: minusf@… Owned by: DarTar
Priority: normal Milestone: 1.1.6.2
Component: actions Version: 1.1.6.1
Severity: normal Keywords: cleanup
Cc:

Description (last modified by dartar) (diff)

yes, i know there's a debate about a menu and staff, but i don't know what's the milestone for that, so meanwhile i cleaned up the old one: phpdoc, got rid of the javascript, syntax based on new guidelines, password forgotten table had incorrect cell count, css-isation (class .loginform), some other stuff

 http://obiit.org/wikka_patches/usersettings.php

See also

#79 #76 [30]

Attachments

usersettings.php Download (9.5 KB) - added by minusf@… 5 years ago.
cleanup

Change History

Changed 5 years ago by dartar

  • description modified (diff)

Hi MinusF,

I can't open your file (the link points to an empty page). Could you upload the file here using the attachment form?

Just a couple of remarks:

  • some preliminary cleanup has already been done in the development version of source:trunk/actions/usersettings.php - see Changeset [30]. I've fixed some problems like the order of error messages and added constants and i18n strings. As soon as you post your patch, I'll take a look at that, but please use the development version of the code for your further patches. You can get the latest version from the repository with a checkout/update following the instructions given on StartPage.
  • the guidelines are still patchy and incomplete (for instance phpdoc guidelines are not yet provided) so I would wait until an agreement is reached on a complete version of the guidelines before applying them. This to avoid extra work in the future.
  • I've added a related (important) item in your ticket description. You might want to take a look at it and at the pointer you'll find on that page.

Changed 5 years ago by minusf@…

sorry, me being idiot today.

 http://obiit.org/wikka_patches/usersettings_php.patch

Changed 5 years ago by minusf@…

cleanup

Changed 4 years ago by DarTar

  • owner changed from unassigned to DarTar
  • status changed from new to assigned

Changed 4 years ago by DarTar

  • status changed from assigned to closed
  • resolution set to fixed

closed in [75]

Changed 4 years ago by DarTar

Help needed. After committing the last code, I'm experiencing problems when logging out. In FF, the logout dialog appears but the user is still logged in. Might this depend on the fact tha the following JS was removed?

http://wush.net/trac/wikka/browser/trunk/actions/usersettings.php?rev=43#L90 http://wush.net/trac/wikka/browser/trunk/actions/usersettings.php?rev=43#L164 ?

Changed 4 years ago by DarTar

The previous reported issue seems to be wrong - I'm testing again with FF and everything works fine. Please double check this.

Changed 4 years ago by NilsLindenberg

I run into the same problem, but only once. Perhaps my deletion of the cookies (testing [79]) solved the problem, but I can only guess?

Changed 4 years ago by DarTar

Fix committed by DotMG [92]

Note: See TracTickets for help on using tickets.