Ticket #11 (closed enhancement: fixed)

Opened 5 years ago

Last modified 12 months ago

Menulets

Reported by: dartar Owned by: DarTar
Priority: lowest Milestone: 1.2
Component: actions Version: 1.1.6.0
Severity: normal Keywords: trunk-unported
Cc:

Description (last modified by BrianKoontz) (diff)

Add available menulets as actions.

Note: some menulets use the new getCount method.

References

Related Tickets

#891 Menu configuration files

Change History

Changed 5 years ago by anonymous

  • milestone changed from 1.1.6.1 to 1.1.7

better move functionality to milestone:1.1.7

Changed 4 years ago by NilsLindenberg

  • description modified (diff)

Changed 15 months ago by DarTar

(In [1375]) First draft of support code for menus: new <tt>MakeMenu()</tt> method, new folder with menu settings (supporting menulets). Changes applied to templates. Installer and config files will need to be updated. First draft of alternate theme called "light" (CSS and images will need to be moved to theme folder): test by setting stylesheet to "light.css" in config file. refs #6 #11 and #868

Changed 15 months ago by DarTar

  • owner changed from unassigned to DarTar
  • status changed from new to assigned
  • milestone changed from 1.3 to 1.2

Changed 15 months ago by DarTar

(In [1379]) Adding missing menulets for footer menu, refs #11 and #891

Changed 15 months ago by DarTar

(In [1383]) Adding missing menulet for footer menu, refs #11 and #891

Changed 15 months ago by DarTar

(In [1384]) Displaying search field on main menu, refs #11 and #891

Changed 15 months ago by DarTar

(In [1385]) New menulets, refs #11 and #891

Changed 15 months ago by DarTar

(In [1387]) Changed link text for consistency, refs #11

Changed 15 months ago by DarTar

(In [1390]) New menulets, refs #11 and #891

Changed 14 months ago by DarTar

(In [1412]) Adding "who am I" menulet, refs #6 #11 and #891

Changed 14 months ago by MasinAlDujaili

Is it really smart to add new files and hard code language strings in them? Shouldn't those use constants already, ready for outsourcing to language files? BTW: {{whoami}} should just output the current user's name oder IP without anything around it -- this way it would have uses beyond those imagined by the devs and without any unneccessary changes to files from Wikka. The strings "You are ..." and "Hello ..." should be outside of {{whoami}}.

Changed 14 months ago by DarTar

Hi Masin - as you probably know, language files are outside the scope of 1.2 (they are available as of 1.3 that will be derived from trunk, while 1.2 is based on the 1.1.X codebase). So I'm afraid you will still find parts of 1.2 not ready for full GUI translation. OTOH I agree I should have separated language strings as constants.

And you're right, your point about externalizing strings is a good one (we could put those in the menu config files, for example) although nothing prevents you from writing a {{username}} action doing exactly what you wish ({{whoami}} is 5 lines or so and was really meant to be a menulet).

Changed 14 months ago by DarTar

(In [1416]) Removing hardcoded strings from whoami menulet, changing menu config settings accordingly (thanks MasinAlDujaili for the heads up), refs #11 and #891

Changed 13 months ago by BrianKoontz

  • status changed from assigned to testing

Changed 13 months ago by DarTar

(In [1428]) Changed wording to avoid potential confusion, refs #11 and #891

Changed 13 months ago by DarTar

(In [1443]) homepage link menulet, refs #11 and #891

Changed 13 months ago by DarTar

(In [1444]) patch for homepage link menulet, refs #11 and #891

Changed 12 months ago by BrianKoontz

  • description modified (diff)

Changed 12 months ago by BrianKoontz

  • status changed from testing to commit

Added clarification to description (to indicate connection to new menu template system). Tested new menus for each default theme, along with the homepagelink action.

Changed 12 months ago by BrianKoontz

  • status changed from commit to closed
  • resolution set to fixed

Changed 12 months ago by BrianKoontz

  • description modified (diff)

Changed 12 months ago by DarTar

(In [1455]) Moving label to constant, semantically improved form, refs #11

Changed 12 months ago by DarTar

(In [1456]) Moving GUI text to constants, refs #11

Changed 12 months ago by BrianKoontz

  • keywords trunk-unported added
Note: See TracTickets for help on using tickets.