Ticket #1091 (closed defect: invalid)

Opened 3 years ago

Last modified 3 years ago

Interwiki Links with Spaces are incorrectly parsed due to deprecated code

Reported by: cygnusfear Owned by: BrianKoontz
Priority: normal Milestone: 1.3.2
Component: unspecified Version: 1.2
Severity: normal Keywords:
Cc:

Description

The following snippet of code breaks the parsing of links such as:

[[Advanced Combat Martial Arts]]
			// Case 2: Deprecated...(first part is a string
			// followed by one or more whitespaces)
			else if(preg_match("/^(.*?)\s+([^|]+)$/s", $contents, $matches) && 
					preg_match("/^[A-ZÄÖÜa-zßäöü][A-Za-z0-9ÄÖÜßäöü]*$/", $matches[1]))
			{
				$url = $matches[1]; 
				$text = $matches[2];
			}

Change History

Changed 3 years ago by BrianKoontz

This functionality is, in fact, deprecated due to the relaxed page naming requirements (i.e., spaces now permitted). Existing links prior to this should not be affected, since spaces were never permitted prior to 1.2. The proper way to encode this link is:

[[Advanced_Combat_Martial_Arts]]

Changed 3 years ago by BrianKoontz

  • owner changed from unassigned to BrianKoontz
  • status changed from new to assigned
  • milestone set to 1.4

Changed 3 years ago by BrianKoontz

  • status changed from assigned to closed
  • resolution set to invalid

Changed 3 years ago by BrianKoontz

  • milestone changed from 1.4 to 1.3.2
Note: See TracTickets for help on using tickets.