Ticket #103 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

lastedit action breaks validation

Reported by: minusf@… Owned by: unassigned
Priority: normal Milestone: 1.1.6.2
Component: actions Version: 1.1.6.1
Severity: normal Keywords: validation
Cc:

Description

hi there,

{{lastedit show="3"}} breaks validation: & is not escaped.

 http://obiit.org/wikka_patches/lastedit_php.patch is a fixed and somewhat more readable version.

Attachments

dartarlastedit.php Download (2.3 KB) - added by dartar 5 years ago.
Some code cleanup

Change History

Changed 5 years ago by dartar

Some code cleanup

Changed 5 years ago by dartar

Hi, I've modified your version to use a phpdoc header; added a bunch of configurable defaults and i18n strings; more compact code using switch.

As for coding conventions, we tend not to use whitespace in string concatenation.

Also, be careful with table suffixes that must be appended without space to $this->config['table_prefix']

Changed 5 years ago by dartar

  • status changed from new to resolved
  • resolution set to fixed

Patch committed in [32]

Changed 5 years ago by minusf@…

  • status changed from resolved to reopened
  • resolution fixed deleted

in the phpdoc header, version should be an svn tag, no?

Changed 5 years ago by dartar

  • status changed from reopened to resolved
  • resolution set to fixed

Yes, it will be something like:

@version SVN: $Id$

or

@version SVN: $Rev$ $Author$

this will have to be applied to all code as soon as we reach an agreement on code documentation guidelines.

Please note that this ticket is fixed because the issue you requested (validation problem) is resolved. This doesn't obviously exclude that the code can undergo further modifications before it is released. Please bear in mind that what is closed in the tracker is a specific request, not the development of an action. So you should only reopen an issue if you think that the original request has not been resolved.

Changed 3 years ago by JavaWoman

  • status changed from reopened to closed
  • resolution set to fixed

Seems to have been reopened by spam removal; closing again...

Note: See TracTickets for help on using tickets.