IsWikiName() review

[DarTar]

With the removal of the CamelCase requirement on pagenames and usernames (#191) and the full support of Unicode and spaces, we need to carefully review the use of IsWikiName() to make sure that we do not enforce constraints that have been removed in 1.3.

Examples include:

• the clone handler;
• the edit handler;
• the newpage action;
• the usersettings action;

The FormattingRules page should also be updated to match the new linking options as described in the docs.

Related tickets

• #191 Making CamelCase optional

[DarTar]

(In [1701]) Urldecoding redirect session parameter (which renders encoded Unicode pagenames otherwise), refs#1003

[DarTar]

linebreaks and commas in usernames are likely to break ACL settings (both at config and page level)

[BrianKoontz]

Other than testing each of these handlers to ensure they work correctly with Unicode strings (which I've done), what else might I look for?

[BrianKoontz]

Replying to DarTar:

linebreaks and commas in usernames are likely to break ACL settings (both at config and page level)

Linebreaks should definitely be prohibited (in fact, all nonprintable chars from 0x00 through 0x1F). At this point, it would be easier to exclude commas from our regexp, and add it back later if the Wikka masses clamor for its return.