Changeset 722

Timestamp:

08/15/2007 11:59:13 AM (3 years ago)

Author:

JavaWoman

Message:

small tweaks to feedback action:

• improved splitting of admins list in config
• retrieve admin email from DB rather than from config (DB is more likely to be current)
• suppress "manual" addition of To: header since PHP (or MTA?) adds the envelope-to also to the headers and some mail servers don't filter duplicate mails to the same address

refs #547

Files:

• trunk/actions/feedback/feedback.php (modified) (2 diffs)

trunk/actions/feedback/feedback.php

@@ -128 +128 @@
                 //default recipient is admin
                 default:
-                        $admins = preg_split('/\s*,\s*/',trim($this->GetConfigValue('admin_users')));
-                        $recipient_name = $admins[0];
-                        $recipient_email = $this->GetConfigValue('admin_email');
+                        $adminarray = preg_split('/\s*,\s*/',trim($this->GetConfigValue('admin_users')), -1, PREG_SPLIT_NO_EMPTY);
+                        $recipient_name = $adminarray[0];
+                        $admin = $this->loadUserData($this->tag);
+                        $recipient_email = $admin['admin_email'];       // get email from DB rather than config!
                         $b_admin = TRUE;
                         break;
@@ -205 +206 @@
                         $msg .= FEEDBACK_EMAIL_LABEL."\t".$sender_email.$eol;
                         $msg .= $eol.$comments.$eol;
-                        $add_headers .= 'To: '.$recipient.$eol;                 // adding full address
+                        #$add_headers .= 'To: '.$recipient.$eol;                        // adding full address - may lead to duplicate mails: suppressing for now
                         $add_headers .= 'From: '.$sender.$eol;                  // adding full address
                         $add_headers .= 'Reply-To: '.$sender.$eol;              // adding full address